fix(init): fund existing accounts; update contractsDir #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnando
reviewed
Dec 9, 2024
chadoh
force-pushed
the
fix/init/contractsDir-and-funding
branch
2 times, most recently
from
a10a0c1 to
97813da
Compare
- if accounts already exist, - don't panic (that's the `| true`) - fund them - use `.stellar` directory, not `.soroban` (and extract to a variable) - rm unused `id` var - build contracts after binding - switch to `STELLAR_*` env vars, rather than obsolete `SOROBAN_*`
chadoh
force-pushed
the
fix/init/contractsDir-and-funding
branch
from
97813da to
ccf22c1
Compare
chadoh
added a commit
to AhaLabs/stellar-docs
that referenced
this pull request
Dec 11, 2024
And just make sure it works, in general. It was pretty broken. Relies on these fixes: - stellar/soroban-template-astro#13 - stellar/soroban-template-astro#14 And can be cleaned up once this is merged: - Creit-Tech/Stellar-Wallets-Kit#49
chadoh
added a commit
to AhaLabs/stellar-docs
that referenced
this pull request
Dec 11, 2024
And just make sure it works, in general. It was pretty broken. Relies on these fixes: - stellar/soroban-template-astro#13 - stellar/soroban-template-astro#14 And can be cleaned up once this is merged: - Creit-Tech/Stellar-Wallets-Kit#49
chadoh
added a commit
to AhaLabs/stellar-docs
that referenced
this pull request
Dec 11, 2024
And just make sure it works, in general. It was pretty broken. Relies on these fixes: - stellar/soroban-template-astro#13 - stellar/soroban-template-astro#14 And can be cleaned up once this is merged: - Creit-Tech/Stellar-Wallets-Kit#49
chadoh
added a commit
to AhaLabs/stellar-docs
that referenced
this pull request
Dec 11, 2024
And just make sure it works, in general. It was pretty broken. Relies on these fixes: - stellar/soroban-template-astro#13 - stellar/soroban-template-astro#14 And can be cleaned up once this is merged: - Creit-Tech/Stellar-Wallets-Kit#49
janewang
pushed a commit
to stellar/stellar-docs
that referenced
this pull request
Jan 10, 2025
And just make sure it works, in general. It was pretty broken. Relies on these fixes: - stellar/soroban-template-astro#13 - stellar/soroban-template-astro#14 And can be cleaned up once this is merged: - Creit-Tech/Stellar-Wallets-Kit#49
elizabethengelman
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| true).stellardirectory, not.soroban(and extract to a variable)idvarSTELLAR_*env vars, rather than obsoleteSOROBAN_*